Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GroupImpl::RemoveAll #1244

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Conversation

madebr
Copy link
Contributor

@madebr madebr commented Dec 20, 2024

Implement GroupImpl::RemoveAll: accuracy is 81.30%

@foxtacles
Copy link
Member

foxtacles commented Dec 20, 2024

Improved the match slightly. TGL stuff is notoriously hard to match because the developers used a complex template abstraction layer (as seen in the Alpha source code) which we don't. However, it's necessary to match a lot of the code so we will have to re-do the TGL library in their style if we want to make further improvements to accuracy.

@foxtacles foxtacles merged commit b338a66 into isledecomp:master Dec 20, 2024
12 checks passed
@madebr madebr deleted the groupimpl-removeall branch December 20, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants